qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise ma


From: Hongbo Zhang
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v2 2/2] hw/arm: Add Arm Enterprise machine type
Date: Thu, 30 Aug 2018 15:07:29 +0800

On 29 August 2018 at 21:42, Andrew Jones <address@hidden> wrote:
> On Wed, Aug 29, 2018 at 05:17:20PM +0800, Hongbo Zhang wrote:
>> On 17 August 2018 at 21:37, Peter Maydell <address@hidden> wrote:
>> > On 25 July 2018 at 06:30, Hongbo Zhang <address@hidden> wrote:
>> >> For the Aarch64, there is one machine 'virt', it is primarily meant to
>> >> run on KVM and execute virtualization workloads, but we need an
>> >> environment as faithful as possible to physical hardware, for supporting
>> >> firmware and OS development for pysical Aarch64 machines.
>> >>
>> >> This patch introduces new machine type 'Enterprise' with main features:
>> >>  - Based on 'virt' machine type.
>> >>  - Re-designed memory map.
>> >>  - EL2 and EL3 are enabled by default.
>> >>  - GIC version 3 by default.
>> >>  - AHCI controller attached to system bus, and then CDROM and hard disc
>> >>    can be added to it.
>> >>  - EHCI controller attached to system bus, with USB mouse and key board
>> >>    installed by default.
>> >>  - E1000E ethernet card on PCIE bus.
>> >>  - VGA display adaptor on PCIE bus.
>> >>  - Default CPU type cortex-a57, 4 cores, and 1G bytes memory.
>> >>  - No virtio functions enabled, since this is to emulate real hardware.
>> >>  - No paravirtualized fw_cfg device either.
>> >>
>> >> Arm Trusted Firmware and UEFI porting to this are done accordingly.
>> >>
>> >> Signed-off-by: Hongbo Zhang <address@hidden>
>> >> ---
>> >> Changes since v1:
>> >>  - rebase on v3.0.0-rc0
>> >>  - introduce another auxillary patch as 1/2, so this is 2/2
>> >>  - rename 'sbsa' to 'enterprise'
>> >>  - remove paravirualized fw_cfg
>> >>  - set gic_vertion to 3 instead of 2
>> >>  - edit commit message to describe purpose of this platform
>> >
>> > Hi; there's been a lot of discussion on this thread. I'm going
>> > to assume that you don't need any further review commentary for
>> > the moment, and will wait for a v3. If there are any specific
>> > questions you want guidance on to produce that v3, let me know.
>> >
>> Thank you for this summary/remind.
>> Sorry for the late reply due to my vacation last week.
>>
>> Yes, I am working on the v3, with main changes:
>>  - machine name "sbsa-ref" (good name?)
>>  - a separate file sbsa-ref.c
>>  - don't touch the acpi c file, acpi will be supplied by uefi
>
> I agree with the above three bullets.
>
>>  - only necessary dt node, no other peripheral dt nodes
>
> I'm not sure what DT nodes are necessary. After discussing the
> ACPI tables, and that firmware would supply them, I thought we
> also agreed firmware would supply the DTB.
>
Yes, firmware supply ACPI to load OS.
But for DT, It is said that UEFI still needs some DT nodes, at least
for memory size. I am trying to figure out which DT nodes are
mandatory too, it is better we don't have any DT nodes left.

@Ard, @Leif, is there any possibility to remove all the DT nodes?
On real hardware, how does UEFI find the memory size and CPU number?

> Thanks,
> drew
>
>>
>> Before my sending, I still like comments on the above effort, it is
>> feasible/reasonable or not etc, in case I go wrong too much.
>>
>> I also know that some reviewers may like to give comments when they
>> see the patch codes, so if you don't have comments now, you can do it
>> after seeing the patch.
>> Thanks all.
>>
>> > thanks
>> > -- PMM
>>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]