[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 12/22] hw/misc/iotkit-secctl: Wire up
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 12/22] hw/misc/iotkit-secctl: Wire up registers for controlling MSCs |
Date: |
Thu, 23 Aug 2018 18:25:12 +0100 |
On 23 August 2018 at 18:21, Richard Henderson
<address@hidden> wrote:
> On 08/20/2018 07:11 AM, Peter Maydell wrote:
>> The IoTKit does not have any Master Security Contollers itself,
>> but it does provide registers in the secure privilege control
>> block which allow control of MSCs in the external system.
>> Add support for these registers.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>> include/hw/misc/iotkit-secctl.h | 14 +++++++
>> hw/misc/iotkit-secctl.c | 73 +++++++++++++++++++++++++++++----
>> 2 files changed, 79 insertions(+), 8 deletions(-)
>
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>>
>> +static bool needed_always(void *opaque)
>> +{
>> + return true;
>> +}
>
> We really should either make NULL imply just this,
> or export one copy from generic code. Soon...
I sent a patch for doing the former, but it got some pushback
from Juan:
https://patchwork.ozlabs.org/patch/954507/
thanks
-- PMM
- Re: [Qemu-arm] [Qemu-devel] [PATCH 08/22] hw/misc/iotkit-sysctl: Implement IoTKit system control element, (continued)
- [Qemu-arm] [PATCH 11/22] hw/misc/tz-msc: Model TrustZone Master Security Controller, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 10/22] hw/misc/iotkit: Wire up the sysctl and sysinfo register blocks, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 13/22] hw/arm/iotkit: Wire up the lines for MSCs, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 12/22] hw/misc/iotkit-secctl: Wire up registers for controlling MSCs, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 15/22] hw/ssi/pl022: Allow use as embedded-struct device, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 18/22] hw/ssi/pl022: Use DeviceState::realize rather than SysBusDevice::init, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 14/22] hw/arm/mps2-tz: Create PL081s and MSCs, Peter Maydell, 2018/08/20
- [Qemu-arm] [PATCH 16/22] hw/ssi/pl022: Set up reset function in class init, Peter Maydell, 2018/08/20