[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 06/10] target/arm: Implement AArch32 Hyp FARs
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-arm] [PATCH 06/10] target/arm: Implement AArch32 Hyp FARs |
Date: |
Tue, 14 Aug 2018 16:57:50 +0200 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
On Tue, Aug 14, 2018 at 01:42:50PM +0100, Peter Maydell wrote:
> The AArch32 virtualization extensions support these fault address
> registers:
> * HDFAR: aliased with AArch64 FAR_EL2[31:0] and AArch32 DFAR(S)
> * HIFAR: aliased with AArch64 FAR_EL2[63:32] and AArch32 IFAR(S)
>
> Implement the accessors for these. This fixes in passing a bug
> where we weren't implementing the "RES0 from EL3 if EL2 not
> implemented" behaviour for AArch64 FAR_EL2.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target/arm/helper.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 9701e413859..d6e98e9d606 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3847,6 +3847,13 @@ static const ARMCPRegInfo el3_no_el2_cp_reginfo[] = {
> { .name = "HSTR_EL2", .state = ARM_CP_STATE_BOTH,
> .opc0 = 3, .opc1 = 4, .crn = 1, .crm = 1, .opc2 = 3,
> .access = PL2_RW, .type = ARM_CP_CONST, .resetvalue = 0 },
> + { .name = "FAR_EL2", .state = ARM_CP_STATE_BOTH,
> + .opc0 = 3, .opc1 = 4, .crn = 6, .crm = 0, .opc2 = 0,
> + .access = PL2_RW, .type = ARM_CP_CONST, .resetvalue = 0 },
> + { .name = "HIFAR", .state = ARM_CP_STATE_AA32,
> + .type = ARM_CP_CONST,
> + .cp = 15, .opc1 = 4, .crn = 6, .crm = 0, .opc2 = 2,
> + .access = PL2_RW, .resetvalue = 0 },
> REGINFO_SENTINEL
> };
>
> @@ -3922,9 +3929,14 @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
> { .name = "ESR_EL2", .state = ARM_CP_STATE_AA64,
> .opc0 = 3, .opc1 = 4, .crn = 5, .crm = 2, .opc2 = 0,
> .access = PL2_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[2])
> },
> - { .name = "FAR_EL2", .state = ARM_CP_STATE_AA64,
> + { .name = "FAR_EL2", .state = ARM_CP_STATE_BOTH,
> .opc0 = 3, .opc1 = 4, .crn = 6, .crm = 0, .opc2 = 0,
> .access = PL2_RW, .fieldoffset = offsetof(CPUARMState, cp15.far_el[2])
> },
> + { .name = "HIFAR", .state = ARM_CP_STATE_AA32,
> + .type = ARM_CP_ALIAS,
> + .cp = 15, .opc1 = 4, .crn = 6, .crm = 0, .opc2 = 2,
> + .access = PL2_RW,
> + .fieldoffset = offsetofhigh32(CPUARMState, cp15.far_el[2]) },
> { .name = "SPSR_EL2", .state = ARM_CP_STATE_AA64,
> .type = ARM_CP_ALIAS,
> .opc0 = 3, .opc1 = 4, .crn = 4, .crm = 0, .opc2 = 0,
> --
> 2.18.0
>