[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH 3/5] target/arm: Honour HCR_EL2.TGE when raising synch
From: |
Peter Maydell |
Subject: |
[Qemu-arm] [PATCH 3/5] target/arm: Honour HCR_EL2.TGE when raising synchronous exceptions |
Date: |
Tue, 24 Jul 2018 12:59:48 +0100 |
Whene we raise a synchronous exception, if HCR_EL2.TGE is set then
exceptions targeting NS EL1 must be redirected to EL2. Implement
this in raise_exception() -- all synchronous exceptions go through
this function.
(Asynchronous exceptions go via arm_cpu_exec_interrupt(), which
already honours HCR_EL2.TGE when it determines the target EL
in arm_phys_excp_target_el().)
Signed-off-by: Peter Maydell <address@hidden>
---
target/arm/op_helper.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c
index f728f25e4bf..d550978b5b9 100644
--- a/target/arm/op_helper.c
+++ b/target/arm/op_helper.c
@@ -33,6 +33,20 @@ static void raise_exception(CPUARMState *env, uint32_t excp,
{
CPUState *cs = CPU(arm_env_get_cpu(env));
+ if ((env->cp15.hcr_el2 & HCR_TGE) &&
+ target_el == 1 && !arm_is_secure(env)) {
+ /*
+ * Redirect NS EL1 exceptions to NS EL2. These are reported with
+ * their original syndrome register value, with the exception of
+ * SIMD/FP access traps, which are reported as uncategorized
+ * (see DDI0478C.a D1.10.4)
+ */
+ target_el = 2;
+ if (syndrome >> ARM_EL_EC_SHIFT == EC_ADVSIMDFPACCESSTRAP) {
+ syndrome = syn_uncategorized();
+ }
+ }
+
assert(!excp_is_internal(excp));
cs->exception_index = excp;
env->exception.syndrome = syndrome;
--
2.17.1
- [Qemu-arm] [PATCH 0/5] target/arm: Implement HCR_EL2.TGE ("trap general exceptions"), Peter Maydell, 2018/07/24
- [Qemu-arm] [PATCH 3/5] target/arm: Honour HCR_EL2.TGE when raising synchronous exceptions,
Peter Maydell <=
- [Qemu-arm] [PATCH 5/5] target/arm: Treat SCTLR_EL1.M as if it were zero when HCR_EL2.TGE is set, Peter Maydell, 2018/07/24
- [Qemu-arm] [PATCH 1/5] target/arm: Mask virtual interrupts if HCR_EL2.TGE is set, Peter Maydell, 2018/07/24
- [Qemu-arm] [PATCH 2/5] target/arm: Honour HCR_EL2.TGE and MDCR_EL2.TDE in debug register access checks, Peter Maydell, 2018/07/24
- [Qemu-arm] [PATCH 4/5] target/arm: Provide accessor functions for HCR_EL2.{IMO, FMO, AMO}, Peter Maydell, 2018/07/24