[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/bcm2836: Mark the bcm2836 / b
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH] hw/arm/bcm2836: Mark the bcm2836 / bcm2837 devices with user_creatable = false |
Date: |
Mon, 16 Jul 2018 16:18:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Thomas Huth <address@hidden> writes:
> These devices are currently causing some problems when a user is trying
> to hot-plug or introspect them during runtime. Since these devices can
> not be instantiated by the user at all (they need to be wired up in code
> instead), we should mark them with user_creatable = false anyway, then we
> avoid at least the crashes with the hot-plugging. The introspection problem
> will be handled by a separate patch.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/arm/bcm2836.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
> index 6805a7d..45d9e40 100644
> --- a/hw/arm/bcm2836.c
> +++ b/hw/arm/bcm2836.c
> @@ -185,6 +185,8 @@ static void bcm283x_class_init(ObjectClass *oc, void
> *data)
> bc->info = data;
> dc->realize = bcm2836_realize;
> dc->props = bcm2836_props;
> + /* Reason: Must be wired up in code (see raspi_init() function) */
> + dc->user_creatable = false;
> }
>
> static const TypeInfo bcm283x_type_info = {
A more common way to phrase this is
/* Reason: needs to be wired-up by raspi_init() */
If you you expect other functions to wire this one up in the future,
insert ", e.g." before "by".
I like consistency in such things, but it's matter of taste, thus:
Reviewed-by: Markus Armbruster <address@hidden>