[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH for-3.0] accel/tcg: Don't treat invalid TLB entrie
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-arm] [PATCH for-3.0] accel/tcg: Don't treat invalid TLB entries as needing recheck |
|
Date: |
Fri, 29 Jun 2018 10:40:18 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/29/2018 09:17 AM, Peter Maydell wrote:
> In get_page_addr_code() when we check whether the TLB entry
> is marked as TLB_RECHECK, we should not go down that code
> path if the TLB entry is not valid at all (ie the TLB_INVALID
> bit is set).
>
> Reported-by: Laurent Vivier <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This fixes the abort that Laurent was seeing with his m68k test case.
Reviewed-by: Richard Henderson <address@hidden>
Also, queued to tcg-next.
r~