qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 13/14] hw/net/smc91c111: Use qemu_log_mask(UNIM


From: Thomas Huth
Subject: Re: [Qemu-arm] [PATCH v2 13/14] hw/net/smc91c111: Use qemu_log_mask(UNIMP) instead of fprintf
Date: Fri, 22 Jun 2018 21:53:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 22.06.2018 15:40, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  hw/net/smc91c111.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
> index 9094c0b47c..d2fd2040e8 100644
> --- a/hw/net/smc91c111.c
> +++ b/hw/net/smc91c111.c
> @@ -362,10 +362,14 @@ static void smc91c111_writeb(void *opaque, hwaddr 
> offset,
>              SET_HIGH(gpr, value);
>              return;
>          case 12: /* Control */
> -            if (value & 1)
> -                fprintf(stderr, "smc91c111:EEPROM store not implemented\n");
> -            if (value & 2)
> -                fprintf(stderr, "smc91c111:EEPROM reload not implemented\n");
> +            if (value & 1) {
> +                qemu_log_mask(LOG_UNIMP,
> +                              "smc91c111: EEPROM store not implemented\n");
> +            }
> +            if (value & 2) {
> +                qemu_log_mask(LOG_UNIMP,
> +                              "smc91c111: EEPROM reload not implemented\n");
> +            }
>              value &= ~3;
>              SET_LOW(ctr, value);
>              return;

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]