[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 11/11] hw/net/smc91c111: Use qemu_log
From: |
Thomas Huth |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 11/11] hw/net/smc91c111: Use qemu_log_mask(GUEST_ERROR) instead of hw_error |
Date: |
Fri, 22 Jun 2018 10:43:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote:
> hw_error() finally calls abort(), but there is no need to abort here.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/net/smc91c111.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
> index c8cc5379b7..705a034cb9 100644
> --- a/hw/net/smc91c111.c
> +++ b/hw/net/smc91c111.c
> @@ -11,6 +11,7 @@
> #include "hw/sysbus.h"
> #include "net/net.h"
> #include "hw/devices.h"
> +#include "qemu/log.h"
> /* For crc32 */
> #include <zlib.h>
>
> @@ -478,7 +479,9 @@ static void smc91c111_writeb(void *opaque, hwaddr offset,
> }
> break;
> }
> - hw_error("smc91c111_write: Bad reg %d:%x\n", s->bank, (int)offset);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "smc91c111_write(bank:%d) 0x%" HWADDR_PRIx " = 0x%x\n",
> + s->bank, offset, value);
> }
>
> static uint32_t smc91c111_readb(void *opaque, hwaddr offset)
> @@ -621,7 +624,9 @@ static uint32_t smc91c111_readb(void *opaque, hwaddr
> offset)
> }
> break;
> }
> - hw_error("smc91c111_read: Bad reg %d:%x\n", s->bank, (int)offset);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "smc91c111_read(bank:%d) 0x%" HWADDR_PRIx "\n",
> + s->bank, offset);
> return 0;
> }
Please keep "bad register" or a similar text in here.
Thomas
- Re: [Qemu-arm] [Qemu-devel] [PATCH 07/11] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, (continued)