[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2] timer/aspeed: fix vmstate version id
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH v2] timer/aspeed: fix vmstate version id |
Date: |
Mon, 23 Apr 2018 13:32:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 04/23/2018 12:29 PM, Peter Maydell wrote:
> On 23 April 2018 at 11:14, Cédric Le Goater <address@hidden> wrote:
>> commit 1d3e65aa7ac5 ("hw/timer: Add value matching support to
>> aspeed_timer") increased the vmstate version of aspeed.timer because
>> the state had changed, but it also bumped the version of the
>> VMSTATE_STRUCT_ARRAY under the aspeed.timerctrl which did not need to.
>>
>> Change back this version to fix migration.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>
> Thanks, applied to target-arm.next.
>
>> To test on a 'palmetto-bmc' board, download the latest built OpenBMC
>> flash image :
>>
>> wget
>> https://openpower.xyz/job/openbmc-build/distro=ubuntu,target=palmetto/lastSuccessfulBuild/artifact/deploy/images/palmetto/flash-palmetto
>>
>> start two instances of QEMU with :
>>
>> qemu-system-arm -m 512 -M palmetto-bmc -drive
>> file=./flash-palmetto,format=raw,if=mtd -serial mon:stdio -nographic
>> -nodefaults
>
> Thanks also for the test image -- I'll add it to the collection I have.
for a romulus-bmc machine, which uses a ARM1176 CPU, you can download this
image :
https://openpower.xyz/job/openbmc-build/distro=ubuntu,target=romulus/lastSuccessfulBuild/artifact/deploy/images/romulus/flash-romulus
but migration fails :
qemu-system-arm: error while loading state for instance 0x0 of device 'cpu'
There seems to be an issue while reading the CPACR reg.
> PS: there seems to be something odd up with the DNS for openpower.xyz:
>
> $ host openpower.xyz
> openpower.xyz has address 146.20.65.228
> ;; connection timed out; no servers could be reached
indeed. hmm, I will report.
Thanks,
C.
> (also manifests as wget pausing for several seconds before starting
> the download).
>
> thanks
> -- PMM
>