[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE l
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 05/67] target/arm: Implement SVE load vector/predicate |
Date: |
Fri, 6 Apr 2018 11:23:03 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/03/2018 07:26 PM, Alex Bennée wrote:
> You don't use it yet but probably worth a:
>
> static inline int ffr_full_reg_offset(DisasContext *s)
> {
> return pred_full_reg_offset(s, 16);
> }
>
> here when you get to it to avoid the magic 16 appearing in the main code.
Hum. Most of the places that ffr is touched is in sve.decode.
I could certainly enhance the grammar there to allow a symbol
there instead of a number.
But I don't think treating ffr differently from a regular pr
register, as above, is a good idea. At best I would use
pred_full_reg_offset(s, FFR_PRED_NUM)
or something.
r~