[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [RFC PATCH 2/6] hw/net/e1000: real device na
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [RFC PATCH 2/6] hw/net/e1000: real device name is 'e1000-82540em', 'e1000' is an alias |
Date: |
Thu, 4 Jan 2018 16:24:01 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Philippe Mathieu-Daudé (address@hidden) wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/net/e1000.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 05a00cba31..2280f7fdf9 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -1648,6 +1648,7 @@ typedef struct E1000Info {
> uint16_t device_id;
> uint8_t revision;
> uint16_t phy_id2;
> + const char **aliases;
> } E1000Info;
>
> static void e1000_class_init(ObjectClass *klass, void *data)
> @@ -1695,10 +1696,11 @@ static const TypeInfo e1000_base_info = {
>
> static const E1000Info e1000_devices[] = {
> {
> - .name = "e1000",
> + .name = "e1000-82540em",
> .device_id = E1000_DEV_ID_82540EM,
> .revision = 0x03,
> .phy_id2 = E1000_PHY_ID2_8254xx_DEFAULT,
> + .aliases = (const char * []) {"e1000", NULL},
> },
> {
> .name = "e1000-82544gc",
> @@ -1725,6 +1727,7 @@ static void e1000_register_types(void)
>
> type_info.name = info->name;
> type_info.parent = TYPE_E1000_BASE;
> + type_info.aliases = info->aliases;
> type_info.class_data = (void *)info;
> type_info.class_init = e1000_class_init;
> type_info.instance_init = e1000_instance_init;
Can you just check that this doesn't break migration compatibility
either way please; I think there's some alias code somewhere but I
can't remember the details.
One thing I do remember that broke when it previously changed was
entries in PC_COMPAT_* tables like the one in hw/i386/pc_piix.c's
PC_COMPAT_1_3 - so check with an 'info qtree' that the property is OK.
Dave
> --
> 2.15.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-arm] [RFC PATCH 0/6] qom: introduce TypeInfo name aliases, Philippe Mathieu-Daudé, 2018/01/04
- [Qemu-arm] [RFC PATCH 1/6] qom: introduce TypeInfo name aliases, Philippe Mathieu-Daudé, 2018/01/04
- [Qemu-arm] [RFC PATCH 3/6] hw/char/cadence_uart: add FDT aliases, Philippe Mathieu-Daudé, 2018/01/04
- [Qemu-arm] [RFC PATCH 5/6] hw/net/cadence_gem: add FDT names as alias, Philippe Mathieu-Daudé, 2018/01/04
- [Qemu-arm] [RFC PATCH 2/6] hw/net/e1000: real device name is 'e1000-82540em', 'e1000' is an alias, Philippe Mathieu-Daudé, 2018/01/04
- Re: [Qemu-arm] [Qemu-devel] [RFC PATCH 2/6] hw/net/e1000: real device name is 'e1000-82540em', 'e1000' is an alias,
Dr. David Alan Gilbert <=
- [Qemu-arm] [RFC PATCH 6/6] hw/arm/xlnx-zynq: use FDT names for the Cadence GEM, Philippe Mathieu-Daudé, 2018/01/04
- [Qemu-arm] [RFC PATCH 4/6] arm/xlnx-zynq: use FDT names for the Cadence UART, Philippe Mathieu-Daudé, 2018/01/04