[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v1] display: limit irq handler index to TC6393XB_GPIOS
From: |
P J P |
Subject: |
[Qemu-arm] [PATCH v1] display: limit irq handler index to TC6393XB_GPIOS |
Date: |
Tue, 12 Dec 2017 09:45:39 +0530 |
From: Prasad J Pandit <address@hidden>
The ctz32() routine could return value greater than
TC6393XB_GPIOS=16. This could lead to an OOB array access.
Mask 'level' to avoid it.
Reported-by: Moguofang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
hw/display/tc6393xb.c | 1 +
1 file changed, 1 insertion(+)
Update: mask 'level' value to TC6393XB_GPIOS=16
-> https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg01685.html
diff --git a/hw/display/tc6393xb.c b/hw/display/tc6393xb.c
index 74d10af3d4..0ae63605f0 100644
--- a/hw/display/tc6393xb.c
+++ b/hw/display/tc6393xb.c
@@ -172,6 +172,7 @@ static void tc6393xb_gpio_handler_update(TC6393xbState *s)
int bit;
level = s->gpio_level & s->gpio_dir;
+ level &= MAKE_64BIT_MASK(0, TC6393XB_GPIOS);
for (diff = s->prev_level ^ level; diff; diff ^= 1 << bit) {
bit = ctz32(diff);
--
2.13.6
- [Qemu-arm] [PATCH v1] display: limit irq handler index to TC6393XB_GPIOS,
P J P <=