[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 10/30] imx_fec: Reserve full 4K page for the re
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v3 10/30] imx_fec: Reserve full 4K page for the register file |
Date: |
Tue, 21 Nov 2017 17:48:05 +0000 |
On 6 November 2017 at 15:47, Andrey Smirnov <address@hidden> wrote:
> Some i.MX SoCs (e.g. i.MX7) have FEC registers going as far as offset
> 0x614, so to avoid getting aborts when accessing those on QEMU, extend
> the register file to cover 4KB of address space instead of just 1K.
>
> Cc: Peter Maydell <address@hidden>
> Cc: Jason Wang <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>
> Cc: address@hidden
> Cc: address@hidden
> Cc: address@hidden
> Signed-off-by: Andrey Smirnov <address@hidden>
> ---
> hw/net/imx_fec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
> index 48d012cad6..e236bc933c 100644
> --- a/hw/net/imx_fec.c
> +++ b/hw/net/imx_fec.c
> @@ -1252,7 +1252,7 @@ static void imx_eth_realize(DeviceState *dev, Error
> **errp)
> SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
>
> memory_region_init_io(&s->iomem, OBJECT(dev), &imx_eth_ops, s,
> - TYPE_IMX_FEC, 0x400);
> + TYPE_IMX_FEC, 0x1000);
> sysbus_init_mmio(sbd, &s->iomem);
> sysbus_init_irq(sbd, &s->irq[0]);
> sysbus_init_irq(sbd, &s->irq[1]);
> --
I notice that we have an unused #define FSL_IMX25_FEC_SIZE 0x4000 in
fsl-imx25.h, and the Linux device trees for the imx25 define the size
of the FEC register block as 0x4000. Should this be 0x4000 ?
thanks
-- PMM
- [Qemu-arm] [PATCH v3 03/30] imx_fec: Change queue flushing heuristics, (continued)
- [Qemu-arm] [PATCH v3 03/30] imx_fec: Change queue flushing heuristics, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 05/30] imx_fec: Use MIN instead of explicit ternary operator, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 08/30] imx_fec: Use correct length for packet size, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 07/30] imx_fec: Add support for multiple Tx DMA rings, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 06/30] imx_fec: Emulate SHIFT16 in ENETx_RACC, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 10/30] imx_fec: Reserve full 4K page for the register file, Andrey Smirnov, 2017/11/06
- Re: [Qemu-arm] [PATCH v3 10/30] imx_fec: Reserve full 4K page for the register file,
Peter Maydell <=
- [Qemu-arm] [PATCH v3 11/30] sdhci: Add i.MX specific subtype of SDHCI, Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 09/30] imx_fec: Fix a typo in imx_enet_receive(), Andrey Smirnov, 2017/11/06
- [Qemu-arm] [PATCH v3 12/30] sdhci: Implement write method of ACMD12ERRSTS register, Andrey Smirnov, 2017/11/06