[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2] don't hardcode EL1 in extended_addresses_enabl
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled |
Date: |
Tue, 31 Oct 2017 18:15:06 +0000 |
On 31 October 2017 at 18:08, Stefano Stabellini <address@hidden> wrote:
> On Tue, 31 Oct 2017, Peter Maydell wrote:
>> On 31 October 2017 at 17:07, Stefano Stabellini <address@hidden> wrote:
>> > Sorry Peter, I copy/pasted the values from arm32/page.h instead of
>> > arm64/page.h in Xen :-/
>> >
>> > Xen is running at EL2, 64-bit (aarch64). The ATS instruction is "at
>> > s1e2r", used to translate Xen virtual addresses into physical addresses.
>> > This is what breaks.
>>
>> Thanks. OK, so if we change the line in do_ats_write() from
>> if (extended_addresses_enabled(env)) {
>> to
>> if (arm_s1_regime_using_lpae_format(env, mmu_idx)) {
>>
>> does that fix your problem?
>
> Yes, it does! Thank you! Are you going to submit a patch?
Yes, I'll do that Thursday.
thanks
-- PMM