Re: [Qemu-arm] [Qemu-devel] [PATCH 02/20] target/arm: Don't switch to target stack early in v7M exception return

[Richard Henderson]

On 10/06/2017 09:22 AM, Peter Maydell wrote:
> I'm going to change this part of the comment to read
>      * Compare the v8M ARM ARM pseudocode LookUpSP_with_security_mode().
>      * Unlike that pseudocode, we require the caller to pass us in the
>      * SPSEL control bit value; this is because we also use this
>      * function in handling of pushing of the callee-saves registers
>      * part of the v8M stack frame (pseudocode PushCalleeStack()),
>      * and in the tailchain codepath the SPSEL bit comes from the exception
>      * return magic LR value from the previous exception. The pseudocode
>      * opencodes the stack-selection in PushCalleeStack(), but we prefer
>      * to make this utility function generic enough to do the job.
> 
> which hopefully is a little clearer.

Much, thanks.


r~