[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH 03/17] imx_fec: Refactor imx_eth_enable_rx()
From: |
Andrey Smirnov |
Subject: |
[Qemu-arm] [PATCH 03/17] imx_fec: Refactor imx_eth_enable_rx() |
Date: |
Mon, 18 Sep 2017 12:50:46 -0700 |
Refactor imx_eth_enable_rx() to have more meaningfull variable name
than 'tmp' and to reduce number of logical negations done.
Cc: Peter Maydell <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: address@hidden
Cc: address@hidden
Cc: address@hidden
Signed-off-by: Andrey Smirnov <address@hidden>
---
hw/net/imx_fec.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index 75822344fc..84085afe09 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -536,19 +536,19 @@ static void imx_eth_do_tx(IMXFECState *s)
static void imx_eth_enable_rx(IMXFECState *s)
{
IMXFECBufDesc bd;
- bool tmp;
+ bool rx_ring_full;
imx_fec_read_bd(&bd, s->rx_descriptor);
- tmp = ((bd.flags & ENET_BD_E) != 0);
+ rx_ring_full = !(bd.flags & ENET_BD_E);
- if (!tmp) {
+ if (rx_ring_full) {
FEC_PRINTF("RX buffer full\n");
} else if (!s->regs[ENET_RDAR]) {
qemu_flush_queued_packets(qemu_get_queue(s->nic));
}
- s->regs[ENET_RDAR] = tmp ? ENET_RDAR_RDAR : 0;
+ s->regs[ENET_RDAR] = rx_ring_full ? 0 : ENET_RDAR_RDAR;
}
static void imx_eth_reset(DeviceState *d)
--
2.13.5
- [Qemu-arm] [PATCH 00/17] Initial i.MX7 support, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 03/17] imx_fec: Refactor imx_eth_enable_rx(),
Andrey Smirnov <=
- [Qemu-arm] [PATCH 02/17] imx_fec: Do not calculate FEC, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 01/17] imx_fec: Do not link to netdev, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 04/17] imx_fec: Change queue flushing heuristics, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 05/17] imx_fec: Use ENET_FTRL to determine truncation length, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 06/17] imx_fec: Use MIN instead of explicit ternary operator, Andrey Smirnov, 2017/09/18
- [Qemu-arm] [PATCH 07/17] imx_fec: Emulate SHIFT16 in ENETx_RACC, Andrey Smirnov, 2017/09/18