qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-arm] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit
Date: Thu, 14 Sep 2017 14:45:16 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 09/14/2017 02:14 PM, Peter Maydell wrote:
On 7 September 2017 at 20:24, Subbaraya Sundeep <address@hidden> wrote:
Emulated Emcraft's Smartfusion2 System On Module starter
kit.
+static void emcraft_sf2_machine_init(MachineClass *mc)
+{
+    mc->desc = "SmartFusion2 SOM kit from Emcraft (M2S010)";
+    mc->init = emcraft_sf2_s2s010_init;
+    mc->ignore_memory_transaction_failures = true;

Please don't set ignore_memory_transaction_failures in new boards.
This is a legacy-old-code-only flag.
What about adding a such check in scripts/checkpatch.pl ?

    if ($line =~ /ignore_memory_transaction_failures\s+=/) {
ERROR("ignore_memory_transaction_failures() is a legacy-old-code-only flag\n" . $herecurr);
    }


New boards should define enough devices, either properly
or using create_unimplemented_device(), to make whatever code
they're being tested against run.

This is a firm requirement for this code to go into master,
because once we let a board in with the flag set it's almost
impossible to clear it because we don't know what guest
code that previously worked on the board will now break.

thanks
-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]