[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)
From: |
Laurent Vivier |
Subject: |
[Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc) |
Date: |
Tue, 12 Sep 2017 16:01:47 +0200 |
Running QEMU with
qemu-system-ppc64 -M none -nographic -m 256
and executing
dump-guest-memory /dev/null 0 8192
results in segfault
Fix by checking if we have CPU, and exit with
error if there is no CPU:
(qemu) dump-guest-memory /dev/null
this feature or command is not currently supported
Signed-off-by: Laurent Vivier <address@hidden>
---
target/ppc/arch_dump.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c
index 8e9397aa58..95b9ab6f29 100644
--- a/target/ppc/arch_dump.c
+++ b/target/ppc/arch_dump.c
@@ -224,8 +224,15 @@ typedef struct NoteFuncDescStruct NoteFuncDesc;
int cpu_get_dump_info(ArchDumpInfo *info,
const struct GuestPhysBlockList *guest_phys_blocks)
{
- PowerPCCPU *cpu = POWERPC_CPU(first_cpu);
- PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu);
+ PowerPCCPU *cpu;
+ PowerPCCPUClass *pcc;
+
+ if (first_cpu == NULL) {
+ return -1;
+ }
+
+ cpu = POWERPC_CPU(first_cpu);
+ pcc = POWERPC_CPU_GET_CLASS(cpu);
info->d_machine = PPC_ELF_MACHINE;
info->d_class = ELFCLASS;
--
2.13.5
- [Qemu-arm] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault, Laurent Vivier, 2017/09/12
- [Qemu-arm] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm), Laurent Vivier, 2017/09/12
- [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc),
Laurent Vivier <=
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Thomas Huth, 2017/09/12
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Greg Kurz, 2017/09/12
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), David Gibson, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Dr. David Alan Gilbert, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Cornelia Huck, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Laurent Vivier, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Dr. David Alan Gilbert, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Laurent Vivier, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), Dr. David Alan Gilbert, 2017/09/13
- Re: [Qemu-arm] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc), David Gibson, 2017/09/13