qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 05/15] hw/intc/armv7m_nvic.c: Remove out of date c


From: Edgar E. Iglesias
Subject: Re: [Qemu-arm] [PATCH 05/15] hw/intc/armv7m_nvic.c: Remove out of date comment
Date: Wed, 2 Aug 2017 19:48:29 +0200
User-agent: Mutt/1.5.24 (2015-08-30)

On Wed, Aug 02, 2017 at 05:43:51PM +0100, Peter Maydell wrote:
> Remove an out of date comment which says there's only one
> item in the NVIC container region -- we put systick into its
> own device object a while back and so now there are two
> things in the container.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Edgar E. Iglesias <address@hidden>


> ---
>  hw/intc/armv7m_nvic.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index 323e2d4..2e8166a 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -1036,10 +1036,6 @@ static void armv7m_nvic_realize(DeviceState *dev, 
> Error **errp)
>       *  0xd00..0xd3c - SCS registers
>       *  0xd40..0xeff - Reserved or Not implemented
>       *  0xf00 - STIR
> -     *
> -     * At the moment there is only one thing in the container region,
> -     * but we leave it in place to allow us to pull systick out into
> -     * its own device object later.
>       */
>      memory_region_init(&s->container, OBJECT(s), "nvic", 0x1000);
>      /* The system register region goes at the bottom of the priority
> -- 
> 2.7.4
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]