[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v9 05/26] target: [tcg] Redefine DISA
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v9 05/26] target: [tcg] Redefine DISAS_* onto the generic translation framework (DJ_*) |
|
Date: |
Mon, 26 Jun 2017 14:05:18 -0400 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Jun 25, 2017 at 12:03:56 +0300, Lluís Vilanova wrote:
> Temporarily redefine DISAS_* values based on DJ_TARGET. They should
> disappear as targets get ported to the generic framework.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> Acked-by: David Gibson <address@hidden> (ppc)
> Acked-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden> (i386)
> Acked-by: Laurent Vivier <address@hidden> (m68k)
> Reviewed-by: Alex Benée <address@hidden> (arm)
Why don't we just keep DISAS_* instead? That will simplify diffs (i.e.
no need to eventually convert anything to DJ_*), and really DISAS_NEXT
makes more sense than DJ_NEXT. You can define a few generic DISAS_foo's,
plus DISAS_TARGET that the existing DISAS_* can build from.
Also, IMO DJ is a poor choice for an acronym. Am I the only one
immediately thinking of 'disc jockey'? =)
E.