Re: [Qemu-arm] [PATCH 2/2] gen-icount: pass cpu_env as a parameter to gen_* inlines

[Richard Henderson]

On 06/15/2017 04:04 PM, Emilio G. Cota wrote:
> We are relying on cpu_env being defined as a global, yet most
> targets (i.e. all but arm/a64) have it defined as a local variable.
> Luckily all of them use the same "cpu_env" name, but really
> compilation shouldn't break if the name of that local variable
> changed.
>
> This patch fixes it by explicitly passing cpu_env to the gen_*
> inlines that need it. This change also helps paving the way for
> the upcoming "translation loop common to all targets" work.
>
> Signed-off-by: Emilio G. Cota<address@hidden>
> ---

Nack.  If you want to make a change, this should be tcg_ctx.tcg_env.


r~