[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v2 05/24] numa: move source of default CPUs to NUM
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-arm] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards |
Date: |
Wed, 3 May 2017 11:59:35 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, May 03, 2017 at 02:56:59PM +0200, Igor Mammedov wrote:
[...]
> @@ -378,14 +379,16 @@ void parse_numa_opts(MachineClass *mc)
> * rule grouping VCPUs by socket so that VCPUs from the same socket
> * would be on the same node.
> */
> + if (!mc->cpu_index_to_instance_props) {
> + error_report("default CPUs to NUMA node mapping isn't
> supported");
> + exit(1);
> + }
This will make people trying to use -numa on unsupported machines
see a misleading error message: instead of telling them that the
machine doesn't support NUMA at all, the message seems to imply
that NUMA may be supported and we just don't have default NUMA node
mapping support.
Probably a more generic "NUMA is not supported by this
machine-type" message before even trying to parse -numa would be
clearer. (I don't know if another patch in this series already
does that.)
--
Eduardo
- Re: [Qemu-arm] [PATCH v2 03/24] hw/arm/virt: use machine->possible_cpus for storing possible topology info, (continued)
[Qemu-arm] [PATCH v2 04/24] hw/arm/virt: explicitly allocate cpu_index for cpus, Igor Mammedov, 2017/05/03
[Qemu-arm] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards, Igor Mammedov, 2017/05/03
Re: [Qemu-arm] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards,
Eduardo Habkost <=
Re: [Qemu-arm] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards, Eduardo Habkost, 2017/05/03
[Qemu-arm] [PATCH v2 07/24] pc: add node-id property to CPU, Igor Mammedov, 2017/05/03
[Qemu-arm] [PATCH v2 06/24] spapr: add node-id property to sPAPR core, Igor Mammedov, 2017/05/03