Re: [Qemu-arm] [PATCH v3 8/8] qdev: Warning about using object_class_property_add() in new code

[Peter Maydell]

On 26 October 2016 at 17:57, Eduardo Habkost <address@hidden> wrote:
> On Wed, Oct 26, 2016 at 05:48:03PM +0100, Peter Maydell wrote:
>> On 26 October 2016 at 17:30, Eduardo Habkost <address@hidden> wrote:
>> > The only remaining user of object_class_property_add() is
>> > arm_cpu_post_init(), but removing it may take some work. While we
>> > don't change it, warn people to not use the function in new code.
>>
>> This is about the third time I've seen this commit
>> message go past, but:
>>
>>   git grep object_class_property_add target-arm   => no hits
>
> Erm. I meant qdev_property_add_static(). Sorry.
> Commit message needs to be rewritten as:
>
>     qdev: Warning about using qdev_property_add_static() in new code
>
>     The only remaining user of qdev_property_add_static() is
>     arm_cpu_post_init(), but removing it may take some work. While we
>     don't change it, warn people to not use the function in new code.

Can we say what the recommended replacement function is?

thanks
-- PMM