Re: [Qemu-arm] [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9fa6e4b hw: vfio: common: Adapt vfio_listeners for reserved_iova region
6f58b94 hw: vfio: common: vfio_prepare_msi_mapping
e73c1f9 hw: platform-bus: Enable to map any memory region onto the platform-bus
313b445 memory: memory_region_find_by_name
afe3c21 memory: Add reserved_iova region type
403f6a2 hw: vfio: common: Introduce vfio_register_msi_iova
30cd237 hw: vfio: common: vfio_get_iommu_type1_info
22e4efb linux-headers: Partial update for MSI IOVA handling

=== OUTPUT BEGIN ===
Checking PATCH 1/8: linux-headers: Partial update for MSI IOVA handling...
Checking PATCH 2/8: hw: vfio: common: vfio_get_iommu_type1_info...
Checking PATCH 3/8: hw: vfio: common: Introduce vfio_register_msi_iova...
ERROR: externs should be avoided in .c files
#32: FILE: hw/vfio/common.c:222:
+int vfio_register_msi_iova(VFIOContainer *container, hwaddr iova,

total: 1 errors, 0 warnings, 34 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/8: memory: Add reserved_iova region type...
Checking PATCH 5/8: memory: memory_region_find_by_name...
Checking PATCH 6/8: hw: platform-bus: Enable to map any memory region onto the 
platform-bus...
Checking PATCH 7/8: hw: vfio: common: vfio_prepare_msi_mapping...
Checking PATCH 8/8: hw: vfio: common: Adapt vfio_listeners for reserved_iova 
region...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden