[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] hw/arm: Fix Integrator/CP memsz initialization
|
From: |
Jakub Jermář |
|
Subject: |
Re: [Qemu-arm] [PATCH] hw/arm: Fix Integrator/CP memsz initialization |
|
Date: |
Sun, 25 Sep 2016 22:13:06 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/20/2016 07:34 PM, Peter Maydell wrote:
> On 19 September 2016 at 20:54, Jakub Jermář <address@hidden> wrote:
>>
>> * Do not assume memsz is already initialized in integratorcm_init
>> * Calculate memsz directly from MachineState
>> * Get rid of the now unused memsz property
>>
>> Signed-off-by: Jakub Jermar <address@hidden>
>
> Thanks for this patch; this is definitely a bug but I think
> this is not the best way to fix it.
>
> What we should do is add a realize function to the IntegratorCM
> device, and move the code that depends on the value of memsz
> from the init function to the realize function. That way the
> device doesn't have to know anything about the machine.
Thanks, I will be sending a reworked patch shortly.
Jakub