Re: [Qemu-arm] [PATCH 0/7] Improve buffer_is_zero

[Paolo Bonzini]

On 24/08/2016 06:30, address@hidden wrote:
> ERROR: Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt
> #44: FILE: util/cutils.c:289:
> +        __asm volatile("vmovdqu -0x80(%1),%0\n\t"

Other errors can be ignored, but please use __asm__ __volatile__ here or
just __asm__ (I don't think volatile is useful).

Also, perhaps move this function to its own file since you're rewriting
it anyway?

Thanks,

Paolo

> ERROR: externs should be avoided in .c files
> #44: FILE: util/cutils.c:289:
> +        __asm volatile("vmovdqu -0x80(%1),%0\n\t"
> 
> ERROR: Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt
> #72: FILE: util/cutils.c:317:
> +        __asm volatile("vmovdqu -0x40(%1),%0\n\t"
> 
> ERROR: externs should be avoided in .c files
> #72: FILE: util/cutils.c:317:
> +        __asm volatile("vmovdqu -0x40(%1),%0\n\t"
> 
> ERROR: Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt
> #98: FILE: util/cutils.c:343:
> +        __asm volatile("movdqu -0x40(%4),%0\n\t"
> 
> ERROR: externs should be avoided in .c files
> #98: FILE: util/cutils.c:343:
> +        __asm volatile("movdqu -0x40(%4),%0\n\t"
> 
> ERROR: Use of volatile is usually wrong: see 
> Documentation/volatile-considered-harmful.txt
> #132: FILE: util/cutils.c:374:
> +        __asm volatile("movdqu -0x40(%4),%0\n\t"
> 
> ERROR: externs should be avoided in .c files
> #132: FILE: util/cutils.c:374:
> +        __asm volatile("movdqu -0x40(%4),%0\n\t"