[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard ass
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH v3 10/10] palmetto-bmc: remove extra no_sdcard assignement |
Date: |
Wed, 3 Aug 2016 09:03:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 08/03/2016 02:23 AM, Andrew Jeffery wrote:
> On Tue, 2016-08-02 at 19:15 +0200, Cédric Le Goater wrote:
>> Signed-off-by: Cédric Le Goater <address@hidden>
>
> Reviewed-by: Andrew Jeffery <address@hidden>
Thanks for the overall review Andrew,
C.
>> ---
>> hw/arm/aspeed.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
>> index e71500c64bd3..6d7b70df70da 100644
>> --- a/hw/arm/aspeed.c
>> +++ b/hw/arm/aspeed.c
>> @@ -145,7 +145,6 @@ static void palmetto_bmc_class_init(ObjectClass *oc,
>> void *data)
>> mc->no_sdcard = 1;
>> mc->no_floppy = 1;
>> mc->no_cdrom = 1;
>> - mc->no_sdcard = 1;
>> mc->no_parallel = 1;
>> }
>>
- Re: [Qemu-arm] [PATCH v3 07/10] hw/misc: use macros to define hw-strap1 register on the AST2400 Aspeed SoC, (continued)