[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 1/2] hw/misc: fix Aspeed SCU hw-strap2 property
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH 1/2] hw/misc: fix Aspeed SCU hw-strap2 property |
Date: |
Fri, 1 Jul 2016 10:28:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 |
On 07/01/2016 10:02 AM, Peter Maydell wrote:
> On 1 July 2016 at 07:11, Cédric Le Goater <address@hidden> wrote:
>> On 06/30/2016 08:24 PM, Peter Maydell wrote:
>>> On 30 June 2016 at 16:50, Cédric Le Goater <address@hidden> wrote:
>>>> These strap registers are complex enough, let's not mix them.
>>>>
>>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>>
>>> Was there a cover letter for this patchset? I can't find
>>> it in my email...
>>
>> Ah :/ No, I didn't send one as the patches were small and self
>> contained. Should we each time ?
>
> The basic rule is that single standalone patches don't
> need a cover letter; a series with more than one patch
> should have a cover letter. Some of our automated tooling
> gets confused otherwise (also I like to be able to have a
> single email to mark for attention in my mail client).
> These confused me a bit because they had the series
> indicators in the subject (1/2, 2/2) but no cover.
Yes, the email threading was a bit confusing in my mail
client also. Sorry about that.
I will resend with a cover letter. I need to add where
the macros are coming from.
Thanks,
C.