[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidat
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr |
Date: |
Thu, 2 Jun 2016 18:32:03 +0200 |
On Thu, 2 Jun 2016 11:53:22 -0300
Eduardo Habkost <address@hidden> wrote:
> (CCing libvirt folks)
>
> BTW:
>
> On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote:
> [...]
> > > /* Special cases: */
> > > if (!strcmp(name, "xlevel")) {
> > > numvalue = strtoul(val, &err, 0);
> > > if (!*val || *err) {
> > > error_setg(errp, "bad numerical value %s", val);
> > > return;
> > > }
> > > if (numvalue < 0x80000000) {
> > > error_report("xlevel value shall always be >= 0x80000000"
> > > ", fixup will be removed in future
> > > versions");
> > > numvalue += 0x80000000;
> > > snprintf(num, sizeof(num), "%" PRIu32, numvalue);
> > > val = num;
> [...]
> > > } else if (!strcmp(name, "hv-spinlocks")) {
> > > const int min = 0xFFF;
> > >
> > > numvalue = strtoul(val, &err, 0);
> > > if (!*val || *err) {
> > > error_setg(errp, "bad numerical value %s", val);
> > > return;
> > > }
> > > if (numvalue < min) {
> > > error_report("hv-spinlocks value shall always be >= 0x%x"
> > > ", fixup will be removed in future versions",
> > > min);
> > > numvalue = min;
> > > }
>
> Those "fixup will be removed in future versions" warnings are
> present since QEMU 1.7. Assuming that libvirt never allowed those
> invalid values to be used in the configuration (did it?), I
> believe we can safely remove the hv-spinlocks and xlevel fixups
> in QEMU 2.7.
>
> The hv-spinlocks setter already rejects invalid values. We just
> need to make x86_cpu_realizefn() reject invalid xlevel values.
I'll leave axing them to you.
- [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, (continued)
- [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Igor Mammedov, 2016/06/01
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Eduardo Habkost, 2016/06/01
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Igor Mammedov, 2016/06/02
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Eduardo Habkost, 2016/06/02
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Eduardo Habkost, 2016/06/02
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Peter Krempa, 2016/06/02
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Igor Mammedov, 2016/06/02
- Re: [Qemu-arm] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Peter Krempa, 2016/06/03
- Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Igor Mammedov, 2016/06/03
- Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr, Eduardo Habkost, 2016/06/03
- Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr,
Igor Mammedov <=
- [Qemu-arm] [PATCH] target-i386: Remove xlevel & hv-spinlocks option fixups, Eduardo Habkost, 2016/06/02
- Re: [Qemu-arm] [libvirt] [PATCH] target-i386: Remove xlevel & hv-spinlocks option fixups, Eric Blake, 2016/06/02
[Qemu-arm] [PATCH RFC 2/8] target-i386: cpu: move xcc->kvm_required check to reaize time, Igor Mammedov, 2016/06/01
[Qemu-arm] [PATCH RFC 5/8] target-sparc: cpu: use sparc_cpu_parse_features() directly, Igor Mammedov, 2016/06/01
[Qemu-arm] [PATCH RFC 6/8] cpu: use CPUClass->parse_features() as convertor to global properties, Igor Mammedov, 2016/06/01