Re: [Qemu-arm] [PATCH v2] arm: virt-acpi: each MADT.GICC entry as enabled unconditionally

[Peter Maydell]

On 1 February 2016 at 10:48, Igor Mammedov <address@hidden> wrote:
> in current impl. condition
>
> build_madt() {
>   ...
>   if (test_bit(i, cpuinfo->found_cpus))
>
> is always true since loop handles only present CPUs
> in range [0..smp_cpus).
> But to fill usless cpuinfo->found_cpus we do unnecessary
> scan over QOM tree to find the same CPUs.
> So mark GICC as present always and drop not needed
> code that fills cpuinfo->found_cpus.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Shannon Zhao <address@hidden>
> ---
> v2:
>   - drop unused VIRT_ACPI_CPU_ID_LIMIT macro
> v1:
> It's just simple cleanup but I'm trying to generalize
> a bit CPU related ACPI tables and as part of it get rid
> of found_cpus bitmap and if possible cpu_index usage
> in ACPI parts of code.
> ---
>  hw/arm/virt-acpi-build.c         | 26 +++-----------------------
>  include/hw/arm/virt-acpi-build.h |  1 -
>  2 files changed, 3 insertions(+), 24 deletions(-)



Applied to target-arm.next, thanks.

-- PMM