|
From: | Dmitry Osipenko |
Subject: | Re: [Qemu-arm] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired |
Date: | Mon, 25 Jan 2016 22:43:06 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
Hello Peter, 24.01.2016 08:29, Peter Crosthwaite пишет: [snip]
+ if (expired && (counter != 0)) { + /* Wrap around periodic counter. */ + counter = s->limit - counter % s->limit; + }
Noticed another nit here. This should be: counter = s->limit - (counter - 1) % s->limit;So wraparound for counter = -1 is counter = limit (not limit - 1). Will fix it in V12.
I suppose your r-b is still valid, otherwise please let me know. -- Dmitry
[Prev in Thread] | Current Thread | [Next in Thread] |