qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 01/26] armv7m: MRS/MSR handle unprivileged acce


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v2 01/26] armv7m: MRS/MSR handle unprivileged access
Date: Thu, 17 Dec 2015 13:10:30 +0000

On 3 December 2015 at 00:18, Michael Davidsaver <address@hidden> wrote:
> The MRS and MSR instruction handling isn't checking
> the current permission level.
>
> Prevent privlaged from changing writing EPSR fields.
> Access to unknown/undefined special registers not
> fatal (read 0, write ignored) w/ guest error message.

This patch and all the others in this series seem to be
missing your Signed-off-by: line.

(scripts/checkpatch.pl will catch this, among other things.)

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

When you send out this patch in future versions of this series,
please include my Reviewed-by: tag in the commit message
after your signed-off-by line; that way I know I don't have
to recheck it. (If a patch changes much after somebody's
reviewed it you should drop the reviewed-by line and say why
in the cover letter.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]