qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v3 1/8] hw/arm/virt: Add a GPIO contr


From: Peter Maydell
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v3 1/8] hw/arm/virt: Add a GPIO controller
Date: Tue, 1 Dec 2015 13:49:31 +0000

On 1 December 2015 at 13:21, Igor Mammedov <address@hidden> wrote:
> On Mon, 16 Nov 2015 21:23:02 +0800
> address@hidden wrote:
>
>> From: Shannon Zhao <address@hidden>
>>
>> ACPI 5.0 supports GPIO-signaled ACPI Events. This can be used for
>> powerdown, hotplug evnets. Add a GPIO controller in machine virt,
> s/evnets/events/
>
>> to support powerdown, maybe can be used for cpu hotplug. And
>> here we use pl061.
>>


> vvvvv
>> +    nodename = g_strdup_printf("/address@hidden" PRIx64, base);
>> +    qemu_fdt_add_subnode(vbi->fdt, nodename);
>> +    qemu_fdt_setprop_sized_cells(vbi->fdt, nodename, "reg",
>> +                                 2, base, 2, size);
>> +    qemu_fdt_setprop(vbi->fdt, nodename, "compatible", compat, 
>> sizeof(compat));
>> +    qemu_fdt_setprop_cell(vbi->fdt, nodename, "#gpio-cells", 2);
>> +    qemu_fdt_setprop(vbi->fdt, nodename, "gpio-controller", NULL, 0);
>> +    qemu_fdt_setprop_cells(vbi->fdt, nodename, "interrupts",
>> +                           GIC_FDT_IRQ_TYPE_SPI, irq,
>> +                           GIC_FDT_IRQ_FLAGS_LEVEL_HI);
>> +    qemu_fdt_setprop_cell(vbi->fdt, nodename, "clocks", vbi->clock_phandle);
>> +    qemu_fdt_setprop_string(vbi->fdt, nodename, "clock-names", "apb_pclk");
>> +
>> +    g_free(nodename);
> could you split off DT parts into a separate patch pls.

I think they belong in this patch. We should never add a device
to the 'virt' board without having the DT binding for it too.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]