Re: [Qemu-arm] [PATCH 14/16] hw/arm/virt: Wire up memory region to CPUs explicitly

[Peter Maydell]

On 6 November 2015 at 14:45, Edgar E. Iglesias <address@hidden> wrote:
> On Thu, Nov 05, 2015 at 06:15:56PM +0000, Peter Maydell wrote:
>> Wire up the system memory region to the CPUs explicitly
>> by setting the QOM property. This doesn't change anything
>> over letting it default, but will be needed for adding
>> a secure memory region later.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> I'm not sure I understand this, if not set, wouldn't "memory"
> just default to sysmem anyway regardless of if we set
> "secure-memory" or not? I'm probably missing something
> in the init/setup sequence...
>
> Anyway, I don't mind explicitely setting "memory":
> Reviewed-by: Edgar E. Iglesias <address@hidden>

Yes, you're right, it would default to the same thing;
but it seemed clearer to me if the board is going to be
setting memory regions explicitly on the CPU to set them
all rather than letting one default and one not.
(Also it provides an example in the code base of how to
do it right ;-))

thanks
-- PMM