Re: [PATCH] gui: Make AGGREGATE dialog initially show all of the right pane.

[Ben Pfaff]

Thanks, I pushed this.

I wonder whether the variable list widget should set a larger
minimum width, perhaps based on the font size?  That might also
solve the problem.

John Darrington <address@hidden> writes:

> Perhaps ideally something more reliable than a hardcoded 200pixels would be 
> better Since we dont know if it'll be enough if the user has a large font.
>
> However, it is an improvement on my machine, and will probably also be an
> improvement in the majority of users' machines.
>
> On Thu, May 12, 2011 at 10:10:37PM -0700, Ben Pfaff wrote:
>      The AGGREGATE dialog initially had a very narrow left pane, so
>      commit 2e6cffa44ef5 "Aggregate dialog: Initialize HPane widget width
>      on opening" added a callback function to adjust the position of the
>      divider between the panes to half the window's width.  But this
>      happens after the window has been laid out, which means that unless
>      the window is very wide to begin with, it will cause part of the
>      right pane to disappear.
>      
>      I was able to get more consistently good results by forcing a minimum
>      width for the left pane with a width_request, and making the right
>      pane shrinkable below the minimum size needed to show all of it.  A
>      final tweak was to make the left pane automatically grow with the
>      window.
>      
>      If you've already used the Aggregate dialog then your preferences for
>      the window size have been saved, so for testing this it is best to
>      remove $HOME/.config/psppire before each experiment.
>      
>      Bug #31126.
>      ---
>       src/ui/gui/aggregate-dialog.c |    2 +-
>       src/ui/gui/aggregate.ui       |    5 +++--
>       2 files changed, 4 insertions(+), 3 deletions(-)
>      
>      diff --git a/src/ui/gui/aggregate-dialog.c 
> b/src/ui/gui/aggregate-dialog.c
>      index 7414c4d..207bbd4 100644
>      --- a/src/ui/gui/aggregate-dialog.c
>      +++ b/src/ui/gui/aggregate-dialog.c
>      @@ -456,7 +456,7 @@ set_initial_pos (GtkPaned *pane)
>                       "max-position", &max_pos,
>                       NULL);
>       
>      -  gtk_paned_set_position (pane, max_pos / 2);
>      +  gtk_paned_set_position (pane, max_pos);
>       }
>       
>       
>      diff --git a/src/ui/gui/aggregate.ui b/src/ui/gui/aggregate.ui
>      index 193d112..8cbcf2a 100644
>      --- a/src/ui/gui/aggregate.ui
>      +++ b/src/ui/gui/aggregate.ui
>      @@ -17,6 +17,7 @@
>                   <property name="visible">True</property>
>                   <child>
>                     <object class="GtkScrolledWindow" id="scrolledwindow1">
>      +                <property name="width_request">200</property>
>                       <property name="visible">True</property>
>                       <property name="can_focus">True</property>
>                       <property name="hscrollbar_policy">automatic</property>
>      @@ -34,7 +35,7 @@
>                       </child>
>                     </object>
>                     <packing>
>      -                <property name="resize">False</property>
>      +                <property name="resize">True</property>
>                       <property name="shrink">True</property>
>                     </packing>
>                   </child>
>      @@ -337,7 +338,7 @@
>                     </object>
>                     <packing>
>                       <property name="resize">True</property>
>      -                <property name="shrink">True</property>
>      +                <property name="shrink">False</property>
>                     </packing>
>                   </child>
>                 </object>
>      -- 
>      1.7.2.5
>      
>      
>      _______________________________________________
>      pspp-dev mailing list
>      address@hidden
>      https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
Ben Pfaff 
http://benpfaff.org