Re: z-scores not visible

[Ben Pfaff]

"Ferguson, Douglas A" <address@hidden> writes:
> Ben Pfaff writes:
> > "Ferguson, Douglas A" <address@hidden> writes:
> > > Attempting to save z-scores in the Analyze/Descriptive
> > > Statistics/Descriptives -- the column is created as expected,
> > > but the cells are empty?
> > Do they show up if you select Transform|Run Pending Transforms
> > after running Descriptives?
> Yes, they do.  It's an odd extra step for a program that
> intends to clone SPSS, but beggars can't be choosers.  Not a
> big issue for me, now that I understand what's happening.

John, it's easy enough to change the behavior to what Douglas
expects, which seems entirely reasonable to me.  The follow patch
takes care of it.  Is it OK with you if I commit this?

Thanks,

Ben.

--8<--------------------------cut here-------------------------->8--

>From 363026a93e6948cf0d92b80fb744d100de2b5a70 Mon Sep 17 00:00:00 2001
From: Ben Pfaff <address@hidden>
Date: Sat, 6 Mar 2010 10:57:29 -0800
Subject: [PATCH] DESCRIPTIVES: In GUI, generate Z scores immediately instead of 
deferring.

Having the Z scores variable show up immediately, but not the actual Z
scores, confuses users.

Reported by Douglas A Ferguson <address@hidden>.
---
 src/ui/gui/descriptives-dialog.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/ui/gui/descriptives-dialog.c b/src/ui/gui/descriptives-dialog.c
index 9d8502d..cad48b8 100644
--- a/src/ui/gui/descriptives-dialog.c
+++ b/src/ui/gui/descriptives-dialog.c
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2007  Free Software Foundation
+   Copyright (C) 2007, 2010  Free Software Foundation
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -177,6 +177,9 @@ generate_syntax (const struct descriptives_dialog *scd)
 
   g_string_append (string, ".");
 
+  if (gtk_toggle_button_get_active (scd->save_z_scores))
+    g_string_append (string, "\nEXECUTE.");
+
   text = string->str;
 
   g_string_free (string, FALSE);
-- 
1.6.5



-- 
Ben Pfaff 
http://benpfaff.org