Re: PSPP & PSPPIRE running as native windows applications.

[Ben Pfaff]

John Darrington <address@hidden> writes:

> On Wed, Feb 07, 2007 at 09:49:25PM -0800, Ben Pfaff wrote:
>      
>      >      The bad snprintf might also cause segfaults if it fails to 
> terminate
>      >      the string with '\0'.
>      >
>      > Indeed.  In order to mitigate  this problem, it might be a good idea in
>      > rank.q to increase the length of func_abb (rank.q:700) by 1, and
>      > initialise it with zeros.
>      
>      I'd rather seek other solutions (for example, improving gnulib or
>      fixing mingw) before modifying correct PSPP code, not least
>      because I'm liable to forget why code has been changed away from
>      what seems obviously correct.
>
> As a general rule, I  agree.  However, if other solutions prove to be
> ellusive, or inappropriate, then sometimes a quick but "incorrect"
> solution is justified.  If that turns out to be the case, then the
> code should be prominently commented to explain why the "incorrect"
> code has been inserted.

Yes.  However, I'm still hoping for a gnulib or mingw solution to
this.  I don't think we've looked for one yet.

>      We should probably drop this entirely from configure.ac: 
>      
>          AM_CONDITIONAL(unix, test x"$host_os" != x"msdos" )
>          AM_CONDITIONAL(msdos, test x"$host_os" = x"msdos" )
>
> Definitely.  (I have an embarrasing feeling that I was responsible for that).

Maybe for the configure fragment, not for the code that wants
it.  Blame me for that.

I'll plan to make this change soon.

>      I propose this patch:
>      
>      --- debugger.c.~1.2.~    2006-12-16 13:15:30.000000000 -0800
>      +++ debugger.c   2007-02-07 21:37:01.000000000 -0800
>      @@ -18,6 +18,9 @@
>
> I concurr.

Checked in.
-- 
"Let others praise ancient times; I am glad I was born in these."
--Ovid (43 BC-18 AD)