[Pspp-cvs] pspp/src/math/linreg linreg.c ChangeLog

[Jason H Stover]

CVSROOT:        /sources/pspp
Module name:    pspp
Changes by:     Jason H Stover <jstover>        08/04/06 21:59:13

Modified files:
        src/math/linreg: linreg.c ChangeLog 

Log message:
        store intercept in proper place when using QR method

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/math/linreg/linreg.c?cvsroot=pspp&r1=1.28&r2=1.29
http://cvs.savannah.gnu.org/viewcvs/pspp/src/math/linreg/ChangeLog?cvsroot=pspp&r1=1.21&r2=1.22

Patches:
Index: linreg.c
===================================================================
RCS file: /sources/pspp/pspp/src/math/linreg/linreg.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -b -r1.28 -r1.29
--- linreg.c    11 Mar 2008 03:28:48 -0000      1.28
+++ linreg.c    6 Apr 2008 21:59:13 -0000       1.29
@@ -397,10 +397,11 @@
       wk = gsl_multifit_linear_alloc (design->size1, design->size2);
       rc = gsl_multifit_linear (design, Y, param_estimates,
                                cache->cov, &(cache->sse), wk);
-      for (i = 0; i < cache->n_coeffs; i++)
+      for (i = 1; i < cache->n_coeffs; i++)
        {
          cache->coeff[i]->estimate = gsl_vector_get (param_estimates, i);
        }
+      cache->intercept = gsl_vector_get (param_estimates, 0);
       if (rc == GSL_SUCCESS)
        {
          gsl_multifit_linear_free (wk);

Index: ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/src/math/linreg/ChangeLog,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -b -r1.21 -r1.22
--- ChangeLog   11 Mar 2008 03:28:48 -0000      1.21
+++ ChangeLog   6 Apr 2008 21:59:13 -0000       1.22
@@ -1,3 +1,9 @@
+2008-04-06  Jason Stover  <address@hidden>
+
+       * linreg.c (pspp_linreg): For the QR method of getting the least
+       squares estimates, store intercept in cache->intercept
+       instead of coefficienc structure. Partial fix of bug 22788.
+
 2008-03-10  Jason Stover  <address@hidden>
 
        * linreg.c (pspp_linreg): Remove use of coefficient 0 as intercept.