Re: [PATCH v1] libpoke: refactoring NULL check

[Jose E. Marchesi]

> Hi Bruno,
>
>>This use of 'inline' is a recipe for link errors, because
>
> Ugh! I was stuck on the rule of GCC 4.3, thanks for pointing this out!
>
> idk if this Patch has any luck to land but if we want it I can propose
> a V2

I am no keen to factorize singleton expressions like this.  It creates
abstraction and infrastructure that may never be actually used to good
purpose.

Thanks for the patch anyway.  Looking forward to the next one :)

>
> Cheers,
>
>    Vincent.
>
>
> On Thu, Feb 8, 2024 at 8:45 PM Bruno Haible <bruno@clisp.org> wrote:
>
>> > inline bool term_if_is_null(struct pk_term_if *term_if)
>>
>> This use of 'inline' is a recipe for link errors, because:
>>   - The semantics of 'inline' in GNU C have changed around GCC 4.3.
>>   - When a developer compiles without optimization, the function
>>     does not get inlined, but referenced. But since it is not defined
>>     in any *.c file, a link error will result.
>>
>> Better use the 'extern-inline' module from Gnulib [1].
>>
>> Bruno
>>
>> [1]
>> https://www.gnu.org/software/gnulib/manual/html_node/extern-inline.html
>>
>>
>>
>>