Re: GNU poke 3.90.0 timeout

[Jose E. Marchesi]

> Jose E. Marchesi wrote:
>> > On two platforms (Alpine Linux 3.13/s390x and Debian 12/powerpc), poke 
>> > 3.90.1
>> > (+ the committed patches) compiles fine, but "make check" fails:
>> >
>> >   Running /home/bruno/poke-3.90.1.3/testsuite/poke.repl/repl.exp ...
>> >   ...
>> >   ERROR: Failed to spawn 
>> > /home/bruno/poke-3.90.1.3/build/testsuite/../poke/poke (timeout)
>> >
>> > Find attached the two log files.
>> >
>> > Where is this timeout defined? How can it be increased?
>> 
>> $ expect
>> expect1.1> puts $timeout
>> 10
>> expect1.2> set timeout 20
>> 
>> The above is in seconds.
>
> Thanks for the hint. The default in poke in 3 seconds, set in poke.exp.
>
> I see the timeout problem on 5 platforms:
>   - Linux/powerpc64 (Debian 12), 3 seconds are not enough but 10 seconds are.
>   - Linux/s390x (Alpine), 3 seconds are not enough but 10 seconds are.
>   - Linux/mips64 (Debian 8), 3 seconds are not enough but 10 seconds are.
>   - Linux/mips (Debian 8), 10 seconds are not enough but 20 seconds are.
>   - Linux/alpha (Debian 12), even 40 seconds are not enough.
> The builds for Linux/powerpc and Linux/hppa are still running.
>
> I wouldn't like to set a timeout to 60 seconds or more; that could have
> annoying effects on CI runs.
>
> Therefore here's a proposed patch, that fixes things on 4 out of the
> 5 platforms mentioned above.

I think this is reasonable.
Please install in both master and maint/poke-4.
Thanks!

>>From 32c6e04b2b5eba0a8680ce6562020f9d0c561947 Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Wed, 24 Jan 2024 17:07:29 +0100
> Subject: [PATCH] Fix test suite failures on Linux/mips, Linux/powerpc64,
>  Alpine Linux/s390x.
>
> * testsuite/poke.repl/repl.exp: Set the timeout to 20 sec instead of 3 sec.
> ---
>  testsuite/poke.repl/repl.exp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/testsuite/poke.repl/repl.exp b/testsuite/poke.repl/repl.exp
> index bcc7ac04..baeaf8ff 100644
> --- a/testsuite/poke.repl/repl.exp
> +++ b/testsuite/poke.repl/repl.exp
> @@ -26,6 +26,9 @@
>  
>  load_lib ${tool}.exp
>  
> +# Override the general timeout, set in poke.exp.
> +set timeout 20
> +
>  set test "slashes-are-preserved-1"
>  poke_start
>  poke_test_cmd {4 / 2} {2}