Re: [PATCH 5/9] pkl: keep track of current filename in codgen

[Jose E. Marchesi]

> Respect PKL_AST_SRC nodes.
>
> 2023-12-28  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>
>       * libpoke/pkl-gen.h (struct pkl_gen_payload): Add new field
>       `filename'.
>       * libpoke/pkl-gen.c (pkl_gen_ps_src): Populate `filename'
>       field.
>       (pkl_gen_pr_program): Likewise.
> ---
>  ChangeLog         | 8 ++++++++
>  libpoke/pkl-gen.c | 2 ++
>  libpoke/pkl-gen.h | 1 +
>  3 files changed, 11 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index bf85172a..21233ed1 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,11 @@
> +2023-12-28  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
> +
> +     * libpoke/pkl-gen.h (struct pkl_gen_payload): Add new field
> +     `filename'.
> +     * libpoke/pkl-gen.c (pkl_gen_ps_src): Populate `filename'
> +     field.
> +     (pkl_gen_pr_program): Likewise.
> +
>  2023-12-28  Mohammad-Reza Nabipoor  <mnabipoor@gnu.org>
>  
>       * libpoke/pkl-ast.h: Fix comment:
> diff --git a/libpoke/pkl-gen.c b/libpoke/pkl-gen.c
> index da260a61..f08989d3 100644
> --- a/libpoke/pkl-gen.c
> +++ b/libpoke/pkl-gen.c
> @@ -140,6 +140,7 @@ PKL_PHASE_BEGIN_HANDLER (pkl_gen_ps_src)
>  {
>    PKL_GEN_PAYLOAD->in_file_p
>      = (PKL_AST_SRC_FILENAME (PKL_PASS_NODE) != NULL);
> +  PKL_GEN_PAYLOAD->filename = PKL_AST_SRC_FILENAME (PKL_PASS_NODE);
>  }
>  PKL_PHASE_END_HANDLER
>  
> @@ -161,6 +162,7 @@ PKL_PHASE_BEGIN_HANDLER (pkl_gen_pr_program)
>    PKL_GEN_PAYLOAD->in_file_p
>      = (!pkl_compiling_statement_p (PKL_GEN_PAYLOAD->compiler)
>         && !pkl_compiling_expression_p (PKL_GEN_PAYLOAD->compiler));
> +  PKL_GEN_PAYLOAD->filename = PKL_PASS_AST->filename;
>  }
>  PKL_PHASE_END_HANDLER
>  
> diff --git a/libpoke/pkl-gen.h b/libpoke/pkl-gen.h
> index 4638fe0f..69902f74 100644
> --- a/libpoke/pkl-gen.h
> +++ b/libpoke/pkl-gen.h
> @@ -91,6 +91,7 @@ struct pkl_gen_payload
>    int constructor_depth;
>    int mapper_depth;
>    int in_file_p;
> +  char *filename;
>    pkl_env env;
>  };

Please add some documention for FILENAME in the comment above the struct
pkl_gen_payload definition.

Given that, OK.
Thanks!