RE: [Phpgroupware-users] Edit user accounts

[Don Graver (dgraver)]

I do not have addressbook installed, but I agree that the test should be
based on user permissions.

-- Don Graver


-----Original Message-----
From: Dave Hall [mailto:address@hidden 
Sent: Tuesday, October 14, 2003 12:59 AM
To: address@hidden
Subject: Re: [Phpgroupware-users] Edit user accounts


Do you have addressbook installed?  I think the test should be based on
if that user has access to the function or not.

Cheers

Dave


"Don Graver (dgraver)" <address@hidden> wrote:

> OK...so I am now at .510 and have noticed the new 'Add to address
> book'feature on this page, but I think this should be based on 
> whether you
> have address book enabled or not.  Since I do not, I would like to not
> have to manually go in and remove this link.
> 
> Also, I noticed that in the file 
> /phpgwapi/inc/class.accounts_sql.inc.php we have the following in the
> read_repository() function:
> 
>                      $this->data['firstname']
> = $this->db->f('account_firstname');
>                        $this->data['lastname']
> = $this->db->f('account_lastname');
>                        $this->data['account_firstname']        =
> $this->db->f('account_firstname');
>                        $this->data['account_lastname']         =
> $this->db->f('account_lastname');
> 
> Any reason for the reduncancy?
> 
> I only noticed this b/c on my cvs update it did not update this
> functionperfectly and when I edited a user's first and last name, 
> it would cause
> them to be blank.  I'm still working on fixing mine, but just 
> wanted to
> ask.
> 
> -- Don Graver
> 
> 
> _______________________________________________
> Phpgroupware-users mailing list
> address@hidden 
> http://mail.gnu.org/mailman/listinfo/phpgroupware-users
>