phpgroupware-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Phpgroupware-developers] patch for review


From: Sigurd Nes
Subject: RE: [Phpgroupware-developers] patch for review
Date: Wed, 6 Sep 2006 11:18:39 +0200 (CEST)

> Hi all,
>
> In HEAD accounts::id2lid returns the user's full name not the login id.

I assume you mean accounts::id2name

> Some parts of phpgw still rely on the old functionality of
> accounts::id2name, I have implemented it as id2lid.
>
> See http://savannah.gnu.org/patch/?5373
> 
> Any comments are welcomed, if no one objects in the next 24hrs or so, I
> will commit it.
There is also applications::d2name , categories::d2name and interserver::d2name.
I think it risky to rename the calls to only accounts::id2name - I think it 
would be better to keep the "old" accounts::id2name - and rather implement the 
new accounts::id2name as accounts::id2full_name or something.

Regards

Sigurd

reply via email to

[Prev in Thread] Current Thread [Next in Thread]