Re: [pdf-devel] Solution to FS#130

[Franck Lesage]

Hi,

The patch should be attached. I added the definitions of pdf_add/get_i/u32
into pdf-hash-helper.h. I documented the API regarding pdf_add/get_bool and
pdf_add/get_i/u32 in gnupdf.texi. I hope that I have not made mistakes.

Regards

--
Franck


On Fri, May 20, 2011 at 04:48:56PM +0200, Aleksander Morgado wrote:
> On Fri, 2011-05-20 at 15:30 +0200, Aleksander Morgado wrote:
> > On Fri, 2011-05-20 at 14:43 +0200, Franck Lesage wrote:
> > > Hi, I bring you a patch for FS#130. The task seemed to me to be pretty 
> > > easy.
> > > I guess that something will be wrong. I ran the Patch Safety Dispatcher 
> > > and it didn't underline syntax error.
> > > For the first patch I didn't run it... 
> > 
> > Seems ok to me. There was a note in the FS task about using these new
> > methods in the ColorTransform parameter of the DCT filter, but don't do
> > that, I converted that parameter to a boolean in a wip branch I'm
> > working on.
> > 
> 
> Ah, just realised that the patch didn't contain some things:
>   - The pdf-hash-helper.h isn't modified to include the new helper
> methods.
>   - doc/gnupdf.texi should be updated to document the new methods as
> well.
> 
> Could you fix those two things in the patch?
> 
> Thanks!
> 
> -- 
> Aleksander

flesage-patch
Description: Text document