Re: [pdf-devel] New developer and UUID module request

[Albert Meroño Peñuela]

Hi,

Please find attached a new patch implementing UUID test cases. In
addition, the API and implementation of pdf_uuid_generate have been
changed, improving parameter filtering.

Cheers,

Albert

2011/4/22 Jose E. Marchesi <address@hidden>:
>
> Hi Albert.
>
>    +/*
>    + * Test: pdf_uuid_generate_002
>    + * Description:
>    + *   Generate a UUID of a non supported type.
>    + * Success conditions:
>    + *   Generated UUID should be ok.
>    + */
>    +START_TEST (pdf_uuid_generate_002)
>    +{
>    +
>    +  pdf_uuid_t uuid_unknown;
>    +
>    +  /* Create a UUID from an unkown type */
>    +  uuid_unknown = pdf_uuid_generate (1111111222222222333333333);
>    +  fail_if(uuid_unknown.uuid == NULL);
>    +
>    +}
>    +END_TEST
>
> What kind of UUID is the library generating in that case?  It is not
> documented in the reference manual.  I would expect the call to return
> an error.
>
>    +/*
>    + * Test: pdf_uuid_string_003
>    + * Description:
>    + *   Generate an UUID ascii representation, buffer size less than
>    + *   required.
>    + * **FAIL** conditions: The buffer to store the UUID string is too
>    + *   short. The ascii generation should fail.
>    + */
>
> I don't think that build-aux/generate-tsd.pl.in will be happy with that
> **FAIL** conditions entry.
>
> --
> Jose E. Marchesi   address@hidden
> GNU Project         http://www.gnu.org
>

patch-amp-2011-05-17.diff
Description: Text Data