[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Is pdf_fsys_file_get_filesystem really necessary?
|
From: |
jemarch |
|
Subject: |
Re: [pdf-devel] Is pdf_fsys_file_get_filesystem really necessary? |
|
Date: |
Mon, 04 Aug 2008 21:41:11 +0200 |
|
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
> 1. Is this one really needed? It's not used within the FS module, the fs
> attribute of a file is always accessed directly.
> 2. If it stays, it doesn't need a unit test, does it?
That seems dumb. We'll let Jose pass final judgement on it, but if
he's okay with it, I'll just remove it with my next patch of
changes to the FS module.
Please dont. Encapsulation is quite important when managing abstract
data types, and it may be useful to get a reference to the filesystem
that backends a given open file.