Re: [Pan-devel] Some notes

[Duncan]

free pro posted on Wed, 17 Jan 2018 22:59:00 +0200 as excerpted:

> 1. there is some code that displays "save as" dialog if post is large
> enough. That is confusing, because some ppl inline pix, there is no need
> to save anything. header-pane.cc, is_mediumish etc.

FWIW on this one, I've been deploying locally this patch that someone 
posted (probably to pan-user)... in 2014 it would appear... arguing that 
we're no longer in the dialup era context that the "smallish" setting was 
likely composed in.  I think I might have modified it to 10K from 
whatever they actually posted, but it has worked well for me, tho I don't 
do as many binaries as some.  Maybe up mediumish similarly, to say 50K?

(Last line wraps, unwrap before attempting to apply...)

$$ cat /etc/portage/patches/net-nntp/pan/smallish-10k.patch 
--- a/pan/gui/header-pane.cc.old  2014-07-02 01:44:25.000000000 -0700
+++ b/pan/gui/header-pane.cc      2014-07-02 01:49:42.547897074 -0700
@@ -1274,7 +1274,7 @@ namespace
     const Article * a (pane->get_first_selected_article());
     if (a) {
       const size_t lines = a->get_line_count();
-      const bool is_smallish = lines  <= 5000;
+      const bool is_smallish = lines  <= 10000;
       const bool is_mediumish = lines <= 20000;
       const bool image_subject = has_image_type_in_subject (*a);
       const bool is_pictures_newsgroup = pane-
>get_group().to_view().strstr("pictures")!=0;

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman