[Pan-devel] yes, ./autogen.sh needs rerun (Re: still having troubles (Re: Ping K.Haley: latest testing branch updates, I get compiler error in post-ui.cc line 742: ‘_c lose’ not declared.))

[SciFi]

Hi,

On Sat, 23 Oct 2010 11:49:09 -0600, K. Haley wrote:
> 
> On 10/23/2010 5:41 AM, SciFi wrote:
>> post-ui.cc: In function ‘int<unnamed>::close(int)’:
>> post-ui.cc:66: error: ‘_close’ was not declared in this scope
>> post-ui.cc: In member function ‘void pan::PostUI::spawn_editor()’:
>> post-ui.cc:746: error: call of overloaded ‘close(const int&)’ is ambiguous
>> /usr/include/unistd.h:422: note: candidates are: int close(int)
>> post-ui.cc:66: note:                 int<unnamed>::close(int)
>> make[3]: *** [post-ui.o] Error 1
>> make[3]: Leaving directory 
>> `/Volumes/Big1500Doing/Projects/pan2_git2/pan2/pan/gui'
>> […]
>> <<<
>>
>> There is only one place HAVE_CLOSE is found in my local tree
>> even after the ./configure has run:
>> $ grep -nre 'HAVE_CLOSE' .
>> ./pan/gui/post-ui.cc:65:#ifndef HAVE_CLOSE
>> $ _
>> and it is not def’d in my env-vars etc,
>> so I must infer that the ifndef is actually being run
>> causing the mix-up being cited.
>>
>> To work-around this for now, in ./pan/gui/post-ui.cc,
>> I commented–out the ifndef block starting at line 65,
>> and let it see the plain “close” again as-is on line 746.
>> This lets me build the latest testing branch ATM
>> (which I am using to post this message).
>>
>>
> It looks like config.h.in needs to be regenerated.  I think you just
> need to run autoheader to update it.  configure should be testing for
> close now instead of _close.

Good grief,
I saw the patch to configure.in
and forgot to run ./autogen.sh
which is definitely needed to fully bring-in your fix.
(I coulda sworn the make system did that for me, but oh well…)
::blush::

I am now running your code almost 100% 
with the patch I mentioned on Aug.27/28 archived at these places:
<news:address@hidden>
<http://lists.nongnu.org/archive/html/pan-devel/2010-08/msg00000.html>
<http://permalink.gmane.org/gmane.comp.gnome.apps.pan.devel/1143>

And a tiny lil hand-tweak on config.h to let PLATFORM_INFO
mention the gcc build (should be in my headers on this post).

:)