[Openvortex-dev] Re: [ALSA - driver 0001138]: errors when installing au8820 modules

[Raymond]

It seem that no one has informed the bug reporter about the patch and he 
is using Intel X86_64 instead of your AMD 64

https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1138

Alien wrote:
> I don't think it'll be faster, gcc -O2 will have changed it accordingly 
> anyway, without optimization it might be faster, but the thing is that it 
> just looks cleaner...
>
> Op woensdag 8 juni 2005 11:06, schreef Raymond:
>
> > au8830 can be loaded after I change "unsigned long __iomem *mmio" to
> > "void __iomem *mmio" on my 32 bits machine.
> >
> > How can I obtain the disassembly of snd-au8830.o to prove that it run
> > faster than before ( without bitshift ) ?
> >
> > alsa-kernel/pci/au88x0/au88x0.h
> >
> > @@ -41,8 +41,8 @@
> >
> >  #define        VORTEX_DMA_MASK 0xffffffff
> >
> >
> > -#define        hwread(x,y) readl((x)+((y)>>2))
> > -#define        hwwrite(x,y,z) writel((z),(x)+((y)>>2))
> > +#define        hwread(x,y) readl((x)+(y))
> > +#define        hwwrite(x,y,z) writel((z),(x)+(y))
> >
> > @@ -172,7 +172,7 @@
> >
> >         /* PCI hardware resources */
> >         unsigned long io;
> > -       unsigned long __iomem *mmio;
> > +       void __iomem *mmio;
> >         unsigned int irq;
> >         spinlock_t lock;
> >
> >
> >
> > I don't have any MPU401 device to test this change.
> >
> >
> > alsa-kernel/pci/au88x0/au88x0_mpu401.c
> > @@ -95,7 +95,7 @@
> >                 return temp;
> >         }
> >  #else
> > -       port = (unsigned long)(vortex->mmio + (VORTEX_MIDI_DATA >> 2));
> > +       port = (unsigned long)(vortex->mmio + VORTEX_MIDI_DATA);
> >         if ((temp =
> >              snd_mpu401_uart_new(vortex->card, 0, MPU401_HW_AUREAL, port,
> >                                  1, 0, 0, &rmidi)) != 0) {
> > @@ -105,7 +105,7 @@
> >                 return temp;
> >         }
> >         mpu = rmidi->private_data;
> > -       mpu->cport = (unsigned long)(vortex->mmio + (VORTEX_MIDI_CMD >>
> > 2)); +       mpu->cport = (unsigned long)(vortex->mmio + VORTEX_MIDI_CMD);
> > #endif
> >         vortex->rmidi = rmidi;
> >         return 0;