Hey - thanks.
Patches are good :)
From: openexr-devel-bounces+address@hidden [openexr-devel-bounces+address@hidden on behalf of Michael Reinhardt address@hidden
Sent: 11 September 2013 08:48
To: address@hidden
Subject: Re: [Openexr-devel] [Half] HalfTest Failure
Hi,
that sounds wonderful. I can prepare these patches and will send them to you nxt week. I managed to get IlmBase and OpenEXR (including all sample apps) compiled on Win7 x64 with VS2010.
Besides some project file related stuff, there were also some windows related problems in the source code (missing EXPORT and so).
I not so familiar with GIT. If you don't mind, I would create good old patch files. :-)
Michael
Am 11.09.2013 17:39, schrieb Piotr Stanczyk:
Anyone care to send me a patch for this? I'll make a windows clean up branch on github and we can try out a few fixes there.
Hi,
from my point of view, this is a know bug in the Visual Studio compiler configuration. I had the same issues some months ago.
See my mail from 25 May 2013 in order to fix this issue.
Quote from the mentioned mail:
3. Correct the export definition in halfExport.h.
As Peshala correctly stated, the PLATFORM_WINDOWS keyword is never defined in the VS project files. The other base libraries as IlmThread use another way to define their *EXPORT keyword (,which work flawlessly). I simply adjusted their definition to the half
project. As a result you will get this content for halfExport.h (remove every other line of code).
#if defined(OPENEXR_DLL)
#if defined(HALF_EXPORTS)
#define HALF_EXPORT __declspec(dllexport)
#define HALF_EXPORT_CONST extern __declspec(dllexport)
#else
#define HALF_EXPORT __declspec(dllimport)
#define HALF_EXPORT_CONST extern __declspec(dllimport)
#endif
#else
#define HALF_EXPORT
#define HALF_EXPORT_CONST extern const
#endif
Additionally, you should check the VS project files for the correct definition of OPENEXR_DLL (Half and HalfTest) and HALF_EXPORT (only Half).
FYI: The same export definition bug can be found in the Iex project. Although, this does not expose any error in the supplied test suites.
I hope this helps.
Michael
Am 11.09.2013 15:15, schrieb Julien:
Hi,
i have exactly the same problem on windows 7 64 bits.
My CPU is an Intel Xeon E5620 (i7 based).
On release i've got (it seems coding the number 3 as a half fails) :
1> f1 = 1, f2 = 2, h1 = 0.00370026, h2 = 4, h3 = 5
1> h1 = f1 + f2: 0.00370026
-> Crash
On Debug its worse i have:
1> f1 = 1, f2 = 2, h1 = -8.05855e-005, h2 = 0.595703, h3 = 0.720703
-> Crash
Thanks,
Julien
_______________________________________________
Openexr-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/openexr-devel
----------
visit us at
IFA 2013 / Berlin, Germany / 6-11 September / hall 11.1, booth 21 and 15
IBC 2013 / Amsterdam, NL / 13-17 September / Joint Fraunhofer booth 8 B.80
ECOC 2013 / ICC London ExCeL, UK / 23-25 September / booth 307+311
----------
visit us at
IFA 2013 / Berlin, Germany / 6-11 September / hall 11.1, booth 21 and 15
IBC 2013 / Amsterdam, NL / 13-17 September / Joint Fraunhofer booth 8 B.80
ECOC 2013 / ICC London ExCeL, UK / 23-25 September / booth 307+311
|